Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

side_by_side should preview files in a side view #1980

Closed
rchl opened this issue Jun 28, 2022 · 0 comments · Fixed by #1982
Closed

side_by_side should preview files in a side view #1980

rchl opened this issue Jun 28, 2022 · 0 comments · Fixed by #1982

Comments

@rchl
Copy link
Member

rchl commented Jun 28, 2022

Describe the bug
When using side_by_side: true option for commands that support it, if the command opens a quick panel with multiple items, the items open in the main view on changing selection and only on pressing Enter to select an item it opens in the side view. I suppose that it should also show previews in side view like native ST functionality does (for example shift+primary+f12).

To Reproduce
Steps to reproduce the behavior:

  1. Set up keybinding like:
    {
        "command": "lsp_symbol_type_definition",
        "keys": ["f13"],
        "args": {"side_by_side": true},
        "context": [
            {
                "key": "lsp.session_with_capability",
                "operator": "equal",
                "operand": "typeDefinitionProvider"
            },
            {
                "key": "auto_complete_visible",
                "operator": "equal",
                "operand": false
            }
        ]
    },
  1. Press F13 on some symbol that is referenced from multiple places

Expected behavior
Changing selection in quick panel should preview the file in a side by side view.

Environment (please complete the following information):

  • OS: macOS
  • Sublime Text version: 4134
@rchl rchl changed the title side_by_side should also trigger preview in a side view side_by_side should also show the preview in a side view view Jun 28, 2022
@rchl rchl changed the title side_by_side should also show the preview in a side view view side_by_side should preview files in a side view Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants