Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Actions menu not showing all options #1548

Closed
LDAP opened this issue Jan 19, 2021 · 0 comments
Closed

Code Actions menu not showing all options #1548

LDAP opened this issue Jan 19, 2021 · 0 comments
Labels
bug

Comments

@LDAP
Copy link
Contributor

LDAP commented Jan 19, 2021

Describe the bug
As discussed previously with @rwols:
The code action popup shows the correct number code actions, but the menu misses some options.

To Reproduce
Steps to reproduce the behavior:

  1. Install LSP-jdtls.
  2. Create a class in a subfolder (not in the default package).
  3. Remove the package ...; declaration.
  4. Click on the top of the class

Expected behavior
The menu shows the desired code action to add the package declaration.

Screenshots
lsp_bug
Notice the "2 code actions" popup on the right and the menu on the left showing only one.

Environment (please complete the following information):

  • LSP: Commit: 2bf36ca
  • LSP-jdtls: 1.0.0
  • Sublime Text 4094
@rwols rwols added the bug label Jan 20, 2021
rwols added a commit that referenced this issue Jan 20, 2021
@rwols
Fix #1548: when the region is empty, query touching points
eda5e91 
Text points are the positions inbetween the characters in the buffer. A region
is a tuple of two text positions. So a region where r.a == r.b never intersects
with another region unless they are the same. Querying for touching points
behaves differently in this regard.
@LDAP LDAP mentioned this issue Jan 21, 2021
Merged
@rwols rwols closed this as completed in 9054a2a Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwols @LDAP