Fix rename input, remove unmatchable typing for *Command.run

Fixes #755
sublimelsp · Oct 18, 2019 · 8463278 · 8463278
1 parent 1a2af66
commit 8463278
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/plugin/rename.py b/plugin/rename.py
@@ -52,7 +52,7 @@ def input(self, args: dict) -> 'Optional[sublime_plugin.TextInputHandler]':
         else:
             return None
 
-    def run(self, edit: sublime.Edit, new_name: str = "", event: 'Optional[dict]' = None) -> None:
+    def run(self, edit: sublime.Edit, new_name: str, event: 'Optional[dict]' = None) -> None:
         pos = get_position(self.view, event)
         position = get_document_position(self.view, pos)
         if position:

diff --git a/stubs/sublime_plugin.pyi b/stubs/sublime_plugin.pyi
@@ -112,8 +112,9 @@ class WindowCommand(Command):
         ...
 
     # def run_(self, edit_token, args): ...
-    def run(self) -> None:
-        ...
+
+    # def run(self) -> None: (mypy issue #5876).
+    #     ...
 
 
 class TextCommand(Command):
@@ -123,8 +124,8 @@ class TextCommand(Command):
         ...
 
     # def run_(self, edit_token, args): ...
-    def run(self, edit: Edit) -> None:
-        ...
+    # def run(self, edit: Edit) -> None: (mypy issue #5876)
+    #     ...
 
 
 class EventListener: