Upstream Inlay Hints #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate your work but I think it will be more efficient if I just do this and more in a separate PR since we should also update settings and schema to match new server version. |
rchl
reviewed
Aug 29, 2022
|
Replaced by #77 |
|
Cheers mate I'm glad it's being looked at! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that LSP supports inlay hints, and rust-analyzer has upstreamed them it makes sense to upstream inlay hints too so we can finally use the latest version of rust-analyzer instead of the backdated version which uses the legacy system (#73).
There are a few things that need to happen before this PR is merged, I haven't updated the config files to expose all the new features in rust-analyzer as I am not sure what they are and inlay hints appear to still be a bit early days as they're a bit busted at least on my machine (see this comment).
I have gone ahead and removed all the relevant inlay hint code as it doesn't appear to be required with the new system.
rust-analyzer.inlayHints.smallerHintsappears to be broken as well. The other parameters relating to inlay hints seem to work though.Inlay hints can be enabled in the latest github dev version of LSP by setting
"show_inlay_hints": truein LSP's settings.Thanks,
Aaron.