Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "Run test" should re-run the test if Terminus already open #86

Closed
rchl opened this issue Dec 29, 2022 · 4 comments · Fixed by sublimelsp/LSP#2154
Closed

Clicking "Run test" should re-run the test if Terminus already open #86

rchl opened this issue Dec 29, 2022 · 4 comments · Fixed by sublimelsp/LSP#2154

Comments

@rchl
Copy link
Member

rchl commented Dec 29, 2022 •
edited
Loading

Clicking "run test" code lens opens Terminus panel and runs the test but clicking it again when Terminus panel is open doesn't do anything.

Clicking "run test" while Terminus is open should re-run the test in the same panel. Or if we can't do that, then we should close the existing panel and re-open it.
@rchl
Copy link
Member Author

rchl commented Dec 29, 2022

This is actually a bug in LSP (or core even).

@rchl
Copy link
Member Author

rchl commented Dec 29, 2022

Created sublimehq/sublime_text#5805

@rchl rchl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
@rwols
Copy link
Member

rwols commented Dec 29, 2022

I guess we could use make_command_link from LSP.core.views ?

@rchl
Copy link
Member Author

rchl commented Dec 29, 2022

Nice, did not recall that we made a workaround for this specific issue.

@rchl rchl reopened this Dec 29, 2022
rchl added a commit to sublimelsp/LSP that referenced this issue Dec 29, 2022
@rchl
Ensure commands triggered from minihtml run on correct view
c4370f2 
Fixes sublimelsp/LSP-rust-analyzer#86
rchl added a commit to sublimelsp/LSP that referenced this issue Dec 29, 2022
@rchl
Ensure commands triggered from minihtml run on correct view
dcc7524 
Fixes sublimelsp/LSP-rust-analyzer#86
@rchl rchl mentioned this issue Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure commands triggered from minihtml run on correct view sublimelsp/LSP
2 participants
@rchl @rwols