[JavaScript] Meta Numbers #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the `punctuation.definition.numeric` and `storage.type.numeric` by `meta.number.[base|type]` scope.
Instead of using `mantissa` for integers, the more general `value` is
used. The scope scheme was updated to:
meta
number
sign
base
value
mantissa
exponent
type
unit
This commit moves the capture group of the `dec_exponent` from the variable definition to the match rule in order to give PackageDev a chance to highlight all capture groups of the match correctly.
1. Removes `mantissa` and `exponent` sub scopes. 2. Renames `type` to `suffix`
Merged
Applies `meta.number.<type> constant.numeric.[base|value|suffix]`
|
Looks like there are some test failures also |
|
I somehow need a way to run all test cases locally on my windows machine. It's not the first time I miss to update some test files. |
|
You don't use the build variant to run all tests? |
|
It does just freeze ST but nothing else. I therefore even removed it from command palette, because I got sick of killing ST when hitting it by accident. It is meant to run all syntax test files it finds? My impression was it just tries to run all syntaxes against the single file or something like that. |
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
* [JavaScript] Add meta.number
This commit replaces the `punctuation.definition.numeric` and `storage.type.numeric` by `meta.number.[base|type]` scope.
* [JavaScript] Add meta.number.value
Instead of using `mantissa` for integers, the more general `value` is
used. The scope scheme was updated to:
meta
number
sign
base
value
mantissa
exponent
type
unit
* [JavaScript] Move float exponent capture groups
This commit moves the capture group of the `dec_exponent` from the
variable definition to the match rule in order to give PackageDev a
chance to highlight all capture groups of the match correctly.
* [JavaScript] Simplify meta.number scopes
1. Removes `mantissa` and `exponent` sub scopes.
2. Renames `type` to `suffix`
* [JavaScript] Update meta.number scopes
Applies `meta.number.<type> constant.numeric.[base|value|suffix]`
* [JavaScript] Move meta.number to common scope directive
* [JavaScript] Update test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal created from the latest discussion at #2460
It is to illustrate what it means to add meta.number scopes. It means to add one or up to 1 (2) additional capture groups per match pattern to assign meta.numbers.[base|value|suffix]. The complexity is the same for applying meta.numbers on top of below constant.numeric.
Note: It also contains the older more complex solutions for comparison.