[Haskell] Fix type signature context not popping when encountering a guard or an instance declaration. #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to that of the function declaration.
FichteFoll
reviewed
Feb 17, 2019
…e with only whitespace.
FichteFoll
approved these changes
Mar 16, 2019
|
Thank you @jacksoncooper and @FichteFoll! |
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
…guard or an instance declaration. (sublimehq#1885) * Pop type signature context when the indentation is less than or equal to that of the function declaration. * Add tests for sublimehq#1320 and sublimehq#1880. * Don't pop type signature context when encountering a comment or a line with only whitespace. * Update tests for sublimehq#1320 and sublimehq#1880.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1320 and #1880. Shamelessly adapted from
SublimeHaskell's syntax file here.The test on line 75 of
syntax_test_haskell.hswas deleted because it relied on the=operator to pop the type signature context.Sublime's default Haskell syntax is a bit dated and could use a rewrite. There are a number of problems inherent to its current design, like #1321. A merge with
SublimeHaskellmay be a good start, but I've found that it too has a couple of idiosyncrasies. I'm not sure how to best engage the community.