Allow overriding cmd prefix #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the setup script in a GHA environment generally works -- the
sudoprefix is used and doesn't cause problems (Ubuntu GHA runner so it's recognized as linux). However, if a private repo is used to add/replace a service then using sudo prevents the credentials which were associated viadocker login.This is a super simple approach and isn't added to docs/general usage. This use case is kind of specific to some internal testing -- there's not really a reason for a customer to need compatibility with
docker loginsince all of our images are public.