Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Stale data in backlinks view when navigating "back" in history #857

Closed
bfollington opened this issue Aug 9, 2023 · 0 comments · Fixed by #859
Closed

Stale data in backlinks view when navigating "back" in history #857

bfollington opened this issue Aug 9, 2023 · 0 comments · Fixed by #859
Labels
Bug Something isn't working

Comments

@bfollington
Copy link
Collaborator

Backlinks in the past history items can go out-of-date if a note is renamed or updated by a view higher in the navigation stack. This data should refresh along with everything else when the view is presented, so there must be a caching issue that results in the same data for transcludes.

Likely fix: use the sphere cid as the cache key when dealing with cached transcludes (same approach we use for expiring the user profile metadata cache)

@bfollington bfollington added the Bug Something isn't working label Aug 9, 2023
@bfollington bfollington moved this to 🧑‍🌾 In Progress in Subconscious + Noosphere Aug 10, 2023
bfollington added a commit that referenced this issue Sep 7, 2023
Fixes #857

# Changes
- Backlinks are now loaded independently of the memo in both the viewer
and editor
- Backlinks are refreshed regardless of whether the editor content is
refresh on `.appear`
- `DataService.readMemoDetail` and `DataService.readEditorMemoDetail`
are both much simpler due to the introduction of
`DataService.readMemoBacklinks`
- Both the viewer an editor will refresh backlinks and transcludes (in
the case of the viewer) if indexing completes in the BG
- To accomplish this I had to pass `app` down to the viewer and editor
so they can replay select actions
- I'd already done this on the profile, so I refactored into a common
`.fromAppAction` pattern
@github-project-automation github-project-automation bot moved this from 🧑‍🌾 In Progress to 🌱 Done in Subconscious + Noosphere Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
Status: 🌱 Done
Development

Successfully merging a pull request may close this issue.

1 participant