Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Integrate profile detail view with 3p sphere content #479

Closed
bfollington opened this issue Mar 30, 2023 · 0 comments · Fixed by #503
Closed

Integrate profile detail view with 3p sphere content #479

bfollington opened this issue Mar 30, 2023 · 0 comments · Fixed by #503
Assignees
@bfollington
Labels
Enhancement New feature or request Topic: Multiplayer

Comments

@bfollington
Copy link
Collaborator

bfollington commented Mar 30, 2023 •
edited
Loading

Take the UI developed in #321 & #470 and wire it up once #477 is done.

We'll need to develop a service to load the content for profiles, but this will likely be related to our approach in #451.

Questions

  • Are we going to automatically using someone else's petname for a user when you follow them from a profile view?
  • Or is there a profile field for this information?
  • Or should you be forced to name a user when you follow them? But should that field be autopopulated with their preferred name anyway?
This was referenced Mar 30, 2023
Merged
Closed
@bfollington bfollington moved this to 🧑‍🌾 In Progress in Subconscious + Noosphere Mar 30, 2023
@bfollington bfollington self-assigned this Mar 30, 2023
bfollington added a commit that referenced this issue Apr 4, 2023
@bfollington
User Profile View (#470)
a05483c 
Resolves #321 

Aims to introduce the visual components and get the navigation
experience working. We'll wire this up to real data with backing
services in #479.

# Demo

https://user-images.githubusercontent.com/5009316/229040041-a5568de6-3fff-4486-b33d-937f75ba0dd6.mov

# Features
- User profile view with scrollable columns for Recent Posts, Top Posts
and Users Followed
- Integrated into the detail view, can transition between content and
users freely
- Mapped out model and user actions
- DummyData utilities

# Tasks
- [x] Try metadata & noosphere block in meta sheet when omnibox is
tapped
- [x] Design card components for notes & other users
    - [x] Backport to the address book as needed
- [x] Resolve best way to address a user's profile (including Omnibox
rendering & link tapping)
- [x] Use correct types to build profile data (remove `Article`)
- [x] Follow / unfollow button on profile
- [x] Follow button is too big
- [x] Follow / unfollow user from meta sheet (make dynamic)
- [x] Metadata table on sheet (DID, CID, gateway URL)
- [x] Remove `AnyView` (revisit types of `TabbedColumnView`)
- [x] Move / clean up `Generatable` protocol & implementations
- [x] Tidy up props API interface, how does data flow in?
- [x] Stub out service layer to produce & request user profile data
- [x] Config flag + remove all hardcoded HACK and TODO

# Next Up
- #479
- #478
@bfollington bfollington mentioned this issue Apr 13, 2023
Merged
13 tasks
bfollington added a commit that referenced this issue Apr 22, 2023
@bfollington
Load real user profile (#503)
2f382b7 
Resolves #479

# Changes
- Track the traversal path while browsing profiles
- List real data from traversed spheres
- Add support for "Your profile" 
- Populate profile metasheet with actual data
- Rendering support for dotted petnames
- Enable user profile toggle if Noosphere is enabled

# Current Demo

https://user-images.githubusercontent.com/5009316/232977254-b0c56eaf-bc69-4e2e-99d6-2ede12e22bbe.mov

# Tasks
- [x] Loading spinner while fetching profile
- [x] Keep track of spherePath in all detail views, intelligently create
full path to user when tapping link in text
- [x] Handle viewing own profile (set `category`) (wait for
subconsciousnetwork/noosphere#317)
- [x] Change `spherePath` to `ownerPetname` 
    - [x] Create utility to concat two petnames without `nil`
- [x] Formatting pass (line wrapping, naming, clean up AddressBook
abstraction)
- [x] Is this user in my address book (by DID)?
- [x] local AddressBook pattern needs to be split into database and
non-database dependent components
- [x] Handle link taps in text
- [x] Use `sphere_identity` call instead of passing DID's around (from
`noosphere@0.8.4`)
- [x] Opening a note from your profile uses the wrong address (has
petname prefix)
- [x] Profile action button in feed follows the wrong user
    - Might be worth hiding this anyway?
- [x] Omnibar indication of your profile
@github-project-automation github-project-automation bot moved this from 🧑‍🌾 In Progress to 🌱 Done in Subconscious + Noosphere Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bfollington bfollington

Labels
Enhancement New feature or request Topic: Multiplayer
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load real user profile subconsciousnetwork/subconscious
1 participant
@bfollington