Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

fix!: The gateway should not call initialize_tracing #767

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

justinabrahms
Copy link
Contributor

Initializing tracing is the responsibility of a surrounding binary, not library code.

@justinabrahms justinabrahms requested a review from jsantell January 8, 2024 20:04
@justinabrahms justinabrahms changed the title The gateway should not call initialize_tracing chore!: The gateway should not call initialize_tracing Jan 8, 2024
@justinabrahms justinabrahms changed the title chore!: The gateway should not call initialize_tracing fix!: The gateway should not call initialize_tracing Jan 8, 2024
jsantell
jsantell previously approved these changes Jan 8, 2024
Copy link
Contributor

@jsantell jsantell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye initialize_tracing should only be called in main functions in executables and test functions; running a gateway (via orb) initializes this here:

initialize_tracing(None);

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Test flake analysis

status platform features toolchain
🟡 macos-13 test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟢 windows-latest test-kubo,headers stable
🟡 macos-13 test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers nightly
🟢 ubuntu-latest test-kubo,headers stable

Flake summary for macos-13, test-kubo,headers,rocksdb, stable

     Summary [  56.809s] 175 tests run: 175 passed (1 flaky), 1 skipped
   FLAKY 2/6 [   1.900s] noosphere-ns dht::node::test::test_dhtnode_bootstrap

Flake summary for macos-13, test-kubo,headers, stable

     Summary [  66.635s] 176 tests run: 176 passed (1 flaky), 1 skipped
   FLAKY 2/6 [   1.847s] noosphere-ns dht::node::test::test_dhtnode_bootstrap

Initializing tracing is the responsibility of a surrounding binary, not library code.
@justinabrahms justinabrahms force-pushed the init-tracing-not-in-gateway branch from 5aecfd6 to 096696e Compare January 8, 2024 21:25
@justinabrahms justinabrahms enabled auto-merge (squash) January 8, 2024 21:29
@jsantell jsantell self-requested a review January 8, 2024 23:16
@justinabrahms justinabrahms merged commit d388dec into main Jan 8, 2024
22 checks passed
@justinabrahms justinabrahms deleted the init-tracing-not-in-gateway branch January 8, 2024 23:16
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants