This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
fix: Recovery only uses latest version of sphere #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the
/v0alpha1/replicate
route to accept ainclude_content
parameter. The use-case of the parameter is to facilitate a recovery via replication.Additionally, recovery has been changed to use
/v0alpha1/replicate
instead of/v0alpha1/fetch
. We are doing this to head-off the scaling fault where a user cannot successfully recovery if their gateway's sphere has a really long history.The most notable consequence of this change is that a user who recovers their sphere from a gateway will not have any of the "history" of changes prior to the recovery point available on the recovery device. We'll have to reckon with this choice at some point down the road when we move to support end-user views into history.
As of this change,
v0alpha1/fetch
and/v0alpha1/replicate
are probably redundant (withfetch
being a subset ofreplicate
), but for now I think we should leave both in place and decide how to consolidate them in a future change.