This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
Features/sync existing sphere #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tests to confirm that the gateway can correctly update a sphere that it has already seen some revisions for when new revisions are pushed from a client.
HAMT
Send + SyncThis change ended up being a bit more involved than I anticipated. Our HAMT is a fork of the FVM/Forest implementation. We forked it to make it compatible with our async storage interface. Our medium-term plan is to switch to a more built-for-purpose implementation (#1), but this will be an effort unto itself. In the mean time, our fork hadn't been updated to meet
Send + Syncbounds on not-web. Most of the work in this change ended up being making that tweak to the HAMT.Fixes #14
Fixes #17