Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

Noosphere should reject key names that are empty strings #331

Closed
cdata opened this issue Apr 25, 2023 · 0 comments · Fixed by #359
Closed

Noosphere should reject key names that are empty strings #331

cdata opened this issue Apr 25, 2023 · 0 comments · Fixed by #359
Labels
Bug Incorrect or unexpected behavior

Comments

@cdata
Copy link
Collaborator

cdata commented Apr 25, 2023 •
edited
Loading

Currently, Noosphere incorrectly allows a key name to be a zero-length string when initializing a sphere. This leads to confusing errors when trying to look up the key name later. It should be explicitly disallowed.
@cdata cdata added the Bug Incorrect or unexpected behavior label Apr 25, 2023
jsantell added a commit that referenced this issue May 3, 2023
@jsantell
feat: consider creating a new key with an empty string an error. Fixes …
192eee8 
…#331
jsantell added a commit that referenced this issue May 3, 2023
@jsantell
feat: consider creating a new key with an empty string an error. Fixes …
c74a5bc 
…#331
@cdata cdata closed this as completed in 0a0efa6 May 4, 2023
@github-project-automation github-project-automation bot moved this from 🏔️ Icebox to 🌱 Done in Subconscious + Noosphere May 4, 2023
This was referenced May 4, 2023
Merged
Closed
Closed
This was referenced Jul 1, 2023
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Incorrect or unexpected behavior
Projects
Subconscious + Noosphere
Status: 🌱 Done
Milestone
No milestone
1 participant
@cdata