This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
feat!: Traverse the Noosphere vast #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsantell
previously approved these changes
Mar 23, 2023
jsantell
approved these changes
Mar 23, 2023
Merged
This was referenced Mar 27, 2023
This was referenced May 8, 2023
Closed
Closed
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the work in #278 and #283 , this change implements our first take on sphere traversal as outlined in #269. By invoking
SphereContext::traverse_by_petname, a user can move from one sphere to the next with minimum information about the sphere's data format or its relative location on the network.This change implements sphere traversal in Rust, but stops short of adding an FFI; I'll add the FFI in a smaller follow-up change.
Important note: this change breaks our HAMT's data layout. In the past, HAMT values were stored and encoded directly inside a
Vec<KeyValuePair>. As of this change,KeyValuePairinternally holds a link to the data, not the data itself. This reduces the amount of data we have to store, but increases the number of lookups we have to do from storage in order to read the values of a HAMT. We are compensated for this trade-off by transferring less over the wire during replication (and it also simplifies the logic of determining what to stream when replicating).Fixes #269
Fixes #2