This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
feat(cli): Find the nearest ancestor sphere #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI now looks for the nearest ancestor sphere directory when determining what "root" should be used for the purposes of the current action.
jsantell
previously approved these changes
Oct 31, 2022
Merged
This was referenced May 8, 2023
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI now looks for the nearest ancestor sphere directory when determining what "root" should be used for the purposes of the current action.
Notably, in the recorded video demo for #22 we tried to save from a sub-directory and I got an annoying error. With this change, that will no longer happen.