chore: Apply suggested changes from PR feedback

subconsciousnetwork · Dec 3, 2022 · eb7739e · eb7739e
1 parent 98aaeaa
commit eb7739e
Show file tree

Hide file tree

Showing 5 changed files with 135 additions and 54 deletions.
diff --git a/.github/workflows/run_test_suite.yaml b/.github/workflows/run_test_suite.yaml
@@ -105,6 +105,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: Swatinem/rust-cache@v2
+      - uses: google/wireit@setup-github-actions-caching/v1
       - uses: actions-rs/toolchain@v1
         with:
           override: true

diff --git a/rust/noosphere/src/sphere/builder.rs b/rust/noosphere/src/sphere/builder.rs
@@ -114,7 +114,7 @@ impl SphereContextBuilder {
         self
     }
 
-    /// Speciy the URL of an IPFS Kubo RPC API for this application to access
+    /// Specify the URL of an IPFS Kubo RPC API for this application to access
     /// as a contingency when blocks being read from storage are missing
     pub fn reading_ipfs_from(mut self, ipfs_api: Option<&Url>) -> Self {
         self.ipfs_api = ipfs_api.cloned();

diff --git a/typescript/package-lock.json b/typescript/package-lock.json
diff --git a/typescript/packages/orb/package.json b/typescript/packages/orb/package.json
@@ -16,16 +16,25 @@
     "@web/dev-server": "^0.1.34",
     "esbuild": "^0.15.9",
     "typescript": "~4.8.2",
-    "wireit": "^0.8.0"
+    "wireit": "^0.9.0"
   },
   "wireit": {
     "build": {
       "dependencies": [
         "generate_wasm"
       ],
       "command": "tsc --pretty",
+      "clean": "if-file-deleted",
       "files": [
+        "../../tsconfig.base.json",
+        "tsconfig.json",
         "./src/**/*.ts"
+      ],
+      "output": [
+        "./lib/index.js",
+        "./lib/index.d.ts",
+        "./lib/index.js.map",
+        "./tsconfig.tsbuildinfo"
       ]
     },
     "generate_wasm": {

diff --git a/typescript/packages/sphere-viewer/package.json b/typescript/packages/sphere-viewer/package.json
@@ -21,7 +21,7 @@
     "typescript": "~4.8.2",
     "vite": "^3.2.3",
     "vite-plugin-wasm": "^3.1.0",
-    "wireit": "^0.8.0"
+    "wireit": "^0.9.0"
   },
   "wireit": {
     "build": {
@@ -37,12 +37,23 @@
       "dependencies": [
         "../orb:build"
       ],
-      "command": "tsc"
+      "command": "tsc --pretty",
+      "clean": "if-file-deleted",
+      "files": [
+        "../../tsconfig.base.json",
+        "tsconfig.json",
+        "./src/**/*.ts"
+      ],
+      "output": [
+        "./lib/**",
+        "./tsconfig.tsbuildinfo"
+      ]
     },
     "serve": {
       "dependencies": [
         "build"
       ],
+      "service": true,
       "command": "web-dev-server -r ./dist --open"
     },
     "clean": {