Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature vsp read2 #364

Merged
merged 5 commits into from
Jul 29, 2020
Merged

Feature vsp read2 #364

merged 5 commits into from
Jul 29, 2020

Conversation

planes
Copy link
Member

@planes planes commented Jul 24, 2020

This PR enables some of the work Theo did 2 summers ago to make importation of OpenVSP models more automatic. Old OpenVSP versions were missing various API functions that are now available.

Pull Request Checklist

  • Merge in the latest Develop branch changes to your branch
  • Remove .pyc files from your repository:
    • Linux/Mac
      • find . -name *.pyc -delete
    • Windows
      • del /S *.pyc
  • Run automatic regression and makes sure everything is passing
  • Did you make a new regression test that covers your new code?
  • Did you update your docstrings?
  • Did you update your headers to include your name and date?
  • Do a final compare with the Develop branch to be sure what you're changing

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.699% when pulling ab8c858 on feature-vsp_read2 into 9ae2c4b on develop.

@planes planes requested a review from timdmacdo July 24, 2020 16:34
@mclarke2 mclarke2 self-requested a review July 28, 2020 22:12
mclarke2
mclarke2 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@mclarke2 mclarke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed look good and consistent

@planes
Copy link
Member Author

planes commented Jul 28, 2020

They just updated OpenVSP today... I'm going to check to be sure all these changes work before merging.

@planes
Copy link
Member Author

planes commented Jul 29, 2020

This works with the latest version of openvsp

@planes planes merged commit 1ebb9b3 into develop Jul 29, 2020
@planes planes deleted the feature-vsp_read2 branch July 29, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mclarke2 mclarke2 mclarke2 approved these changes

@timdmacdo timdmacdo Awaiting requested review from timdmacdo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@planes @coveralls @mclarke2