Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Hogwarts and Ilvermorny houses to Harry Potter faker #925

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

samanthamorco
Copy link
Contributor

It was bugging me that a Harry Potter faker didn't have the houses on it. This fixes that.

@Joe11000
Copy link
Contributor

Joe11000 commented Jun 15, 2017

A functional +1 from a non "collaborator"

  • I double checked the spellings.
  • Required the gem locally and it works as promised.
  • Travis likes what it sees

@stympy stympy merged commit 1cecbb7 into faker-ruby:master Jul 12, 2017
@samanthamorco samanthamorco deleted the harry-potter branch July 12, 2017 18:38
paneer-tikka added a commit to paneer-tikka/faker that referenced this pull request Aug 4, 2017
* 'master' of github.com:stympy/faker: (56 commits)
  Renamed word_of_warcraft to world_of_warcraft
  Add default_country for Japan and Korea
  Fix typo in de.yml (faker-ruby#986)
  Fix for NL postal code (faker-ruby#984)
  French traduction for Faker::Pokemon (faker-ruby#983)
  Version bump
  Remove errant tab character in YAML (faker-ruby#981)
  Version bump
  Adds Bossa Nova
  Add Umphreys McGee (faker-ruby#942)
  Adds world of warcraft characters and quotes
  Add Faker::TheFreshPrinceOfBelAir
  Add tests for Faker::Address and fix bg with zip_code(state_abbreviation)
  Adds Faker::Measurement
  Adding metric system to food measurements
  Add Hogwarts and Ilvermorny houses to Harry Potter (faker-ruby#925)
  Add Witcher
  Add greek_organization method to University (faker-ruby#932)
  Adds Most Interesting Man In The World quotes
  Adds elder scrolls (faker-ruby#933)
  ...
landongrindheim pushed a commit to landongrindheim/faker that referenced this pull request Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants