Fix for NL postal code #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to wikipedia, https://en.wikipedia.org/wiki/Postal_codes_in_the_Netherlands the postal code for the Netherlands should not include one of SA, SD, SS as a suffix. This is now fixed. Also added test for nl_locale
ghost
deleted the
paneer-tikka
added a commit
to paneer-tikka/faker
that referenced
this pull request
Aug 4, 2017
* 'master' of github.com:stympy/faker: (56 commits) Renamed word_of_warcraft to world_of_warcraft Add default_country for Japan and Korea Fix typo in de.yml (faker-ruby#986) Fix for NL postal code (faker-ruby#984) French traduction for Faker::Pokemon (faker-ruby#983) Version bump Remove errant tab character in YAML (faker-ruby#981) Version bump Adds Bossa Nova Add Umphreys McGee (faker-ruby#942) Adds world of warcraft characters and quotes Add Faker::TheFreshPrinceOfBelAir Add tests for Faker::Address and fix bg with zip_code(state_abbreviation) Adds Faker::Measurement Adding metric system to food measurements Add Hogwarts and Ilvermorny houses to Harry Potter (faker-ruby#925) Add Witcher Add greek_organization method to University (faker-ruby#932) Adds Most Interesting Man In The World quotes Adds elder scrolls (faker-ruby#933) ...
landongrindheim
pushed a commit
to landongrindheim/faker
that referenced
this pull request
Oct 7, 2017
According to wikipedia, https://en.wikipedia.org/wiki/Postal_codes_in_the_Netherlands the postal code for the Netherlands should not include one of SA, SD, SS as a suffix. This is now fixed. Also added test for nl_locale
|
This does not seem to work. When I fill my database using faker in As far as I can see, there is always something added to the zip code. Sometimes its only |
|
Interesting. Is this something that just started occurring or has it been a problem in the past? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to wikipedia, https://en.wikipedia.org/wiki/Postal_codes_in_the_Netherlands
the postal code for the Netherlands should not include one of SA, SD, SS
as a suffix. This is now fixed.
Also added test for nl_locale