Add Faker::PhoneNumber.country_code #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
requested changes
Oct 20, 2018
There was a problem hiding this comment.
Overall looks good 👍
Couple of things:
- Could you add documentation for the new methods? Take a look at
doc/phone_number.md - Could you add tests for these methods as well?
Here is another PR that tried to implement something similar but we couldn't finish the changes to merge them #523
vbrazo
reviewed
Oct 20, 2018
vbrazo
changed the title
…s of country codes, add new line for text
|
@vbrazo Hey, I added required changes as you said. |
vbrazo
approved these changes
Oct 22, 2018
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* adds country code for phone numbers and cel phones * use interpolation for string, move country codes to phone_number file, Add and update country codes data * update documentation with new methods * add + sign in front of country code * update data of country codes, replace spaces with dashes, sort strings of country codes, add new line for text * add test cases for new country code related functions * update test cases, refactor code * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #558