Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Faker::PhoneNumber.country_code #558

Closed
amingilani opened this issue Apr 22, 2016 · 5 comments
Closed

Add Faker::PhoneNumber.country_code #558

amingilani opened this issue Apr 22, 2016 · 5 comments
Labels
💡 Issue: Feature Request

Comments

@amingilani
Copy link

Add a country code generator to the phone numbers!
@lavika
Copy link

lavika commented May 28, 2016

I am working on this.

@lavika lavika mentioned this issue Sep 10, 2016
Closed
@gkunwar
Copy link
Contributor

gkunwar commented May 23, 2018

@lavika how is the progress on this issue?

@vbrazo
Copy link
Member

vbrazo commented Sep 18, 2018

@gkunwar I closed the PR due to inactivity. Do you want to work on it?

@AmrAdelKhalil AmrAdelKhalil mentioned this issue Oct 20, 2018
Merged
@AmrAdelKhalil
Copy link
Contributor

@vbrazo , Hey I noticed this issue got a PR already and almost to be fixed, I added what is needed and updated the PR because it seems to be to old.
Check it and tell me your feedback, please.

@vbrazo
Copy link
Member

vbrazo commented Oct 20, 2018

@AmrAdelKhalil awesome. I've just left a few comments in your PR 💯

@vbrazo vbrazo changed the title Add country code Add Faker::Address.country_code Oct 20, 2018
@vbrazo vbrazo changed the title Add Faker::Address.country_code Add Faker::PhoneNumber.country_code Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💡 Issue: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@amingilani @vbrazo @gkunwar @AmrAdelKhalil @lavika