Target Ruby 2.3 #1311
Merged
Target Ruby 2.3 #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum required version of Ruby supports `Array.sample` and `Symbol.downcase`
|
Awesome, thanks! |
Merged
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Set required Ruby version to 2.3 * Remove useless extensions -- the minimum required version of Ruby supports `Array.sample` and `Symbol.downcase` * Update RuboCop to 0.58.1 * Fix RuboCop offences * Add Frozen String Literals support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I know that "unsopported" doesn't mean "don't work")
Since support for Ruby 2.1 and 2.2 were dropped and there is a 2.0 milestone, this PR contains a proposal to set the minimum required Ruby version to 2.3
I've removed the
lib/extensionsfolder, because the minimum required version of Ruby already support the class methods defined thereI've updated RuboCop and fixed all the new issues
Ruby 2.3 added support for frozen string literals and RuboCop demands
# frozen_string_literal: trueon top of each ruby file, I've fixed the fakers that didn't work with frozen string literals.