Target Ruby 2.3 (#1311)

* Set required Ruby version to 2.3

* Remove useless extensions -- the minimum required version of Ruby supports `Array.sample` and
`Symbol.downcase`

* Update RuboCop to 0.58.1

* Fix RuboCop offences

* Add Frozen String Literals support

.rubocop.yml

@@ -1,3 +1,5 @@
+AllCops:
+  TargetRubyVersion: 2.3
 
 Lint/AmbiguousBlockAssociation:
   Enabled: false

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Remove Rubygems deprecation warnings

Gemfile.lock

@@ -20,17 +20,17 @@ GEM
       addressable (~> 2.3)
     minitest (5.10.3)
     parallel (1.12.1)
-    parser (2.5.1.0)
+    parser (2.5.1.2)
       ast (~> 2.4.0)
     power_assert (1.1.1)
     powerpack (0.1.2)
     public_suffix (3.0.2)
     rainbow (3.0.0)
     rake (12.3.0)
-    rubocop (0.57.2)
+    rubocop (0.58.1)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5)
+      parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift File.dirname(__FILE__)
 
 Dir['tasks/**/*.rake'].each { |rake| load rake }

faker.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.push File.expand_path('lib', __dir__)
 require 'faker/version'
 
@@ -20,7 +22,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('simplecov')
   s.add_development_dependency('test-unit')
   s.add_development_dependency('timecop')
-  s.required_ruby_version = '>= 2.1'
+  s.required_ruby_version = '>= 2.3'
 
   s.files         = Dir['lib/**/*'] + %w[History.md License.txt CHANGELOG.md README.md]
   s.require_paths = ['lib']

lib/faker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 mydir = __dir__
 
 begin
@@ -94,7 +96,7 @@ def regexify(reg)
       # with an array of values and selecting one of them.
       def fetch(key)
         fetched = sample(translate("faker.#{key}"))
-        if fetched && fetched.match(%r{^\/}) && fetched.match(%r{\/$}) # A regex
+        if fetched&.match(%r{^\/}) && fetched&.match(%r{\/$}) # A regex
           regexify(fetched)
         else
           fetched
@@ -214,7 +216,7 @@ def shuffle(list)
       def rand(max = nil)
         if max.nil?
           Faker::Config.random.rand
-        elsif max.is_a?(Range) || max.to_i > 0
+        elsif max.is_a?(Range) || max.to_i.positive?
           Faker::Config.random.rand(max)
         else
           0
@@ -226,8 +228,5 @@ def rand(max = nil)
 
 Dir.glob(File.join(File.dirname(__FILE__), 'faker', '*.rb')).sort.each { |f| require f }
 
-require 'extensions/array'
-require 'extensions/symbol'
-
 require 'helpers/char'
 require 'helpers/unique_generator'

lib/faker/address.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Address < Base
     flexible :address

lib/faker/ancient.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Ancient < Base
     class << self

lib/faker/app.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class App < Base
     class << self

lib/faker/appliance.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Appliance < Base
     class << self

lib/faker/aqua_teen_hunger_force.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class AquaTeenHungerForce < Base
     class << self

lib/faker/artist.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Artist < Base
     class << self

lib/faker/avatar.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Avatar < Base
     class << self

lib/faker/back_to_the_future.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class BackToTheFuture < Base
     class << self

lib/faker/bank.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Bank < Base
     flexible :bank

lib/faker/beer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Beer < Base
     flexible :beer

lib/faker/bitcoin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'digest'
 require 'securerandom'
 
@@ -26,8 +28,8 @@ def base58(str)
         lv = 0
         str.split('').reverse.each_with_index { |v, i| lv += v.unpack('C')[0] * 256**i }
 
-        ret = ''
-        while lv > 0
+        ret = +''
+        while lv.positive?
           lv, mod = lv.divmod(base)
           ret << alphabet[mod]
         end

lib/faker/bojack_horseman.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class BojackHorseman < Base
     class << self

lib/faker/book.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Book < Base
     flexible :book

lib/faker/boolean.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Boolean < Base
     class << self

lib/faker/bossa_nova.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class BossaNova < Base
     class << self

lib/faker/business.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'date'
 
 module Faker

lib/faker/cat.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Cat < Base
     flexible :cat

lib/faker/chuck_norris.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class ChuckNorris < Base
     flexible :name

lib/faker/code.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Code < Base
     flexible :code
@@ -171,7 +173,7 @@ def generate_sin_check_digit(digits)
         ]
         sum = 0
 
-        while len > 0
+        while len.positive?
           len -= 1
           num = digits[len].to_i
           sum += luhn_arr[mul][num]

lib/faker/coffee.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Coffee < Base
     class << self

lib/faker/color.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Color < Base
     class << self

lib/faker/commerce.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Commerce < Base
     class << self

lib/faker/community.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Community < Base
     class << self

lib/faker/company.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Company < Base
     flexible :company

lib/faker/compass.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Compass < Base
     class << self

lib/faker/cosmere.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Cosmere < Base
     flexible :cosmere

lib/faker/crypto.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'digest'
 
 module Faker

lib/faker/currency.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Currency < Base
     class << self

lib/faker/date.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Date < Base
     class << self

lib/faker/demographic.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Demographic < Base
     class << self

lib/faker/dessert.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Dessert < Base
     flexible :dessert

lib/faker/device.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Device < Base
     class << self

lib/faker/dog.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Dog < Base
     flexible :dog

lib/faker/dota.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Dota < Base
     class << self

lib/faker/dragon_ball.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class DragonBall < Base
     class << self

lib/faker/dumb_and_dumber.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class DumbAndDumber < Base
     class << self

lib/faker/dune.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Dune < Base
     class << self
@@ -22,7 +24,7 @@ def quote(character = nil)
         if character.nil?
           character = sample(quoted_characters).to_s
         else
-          character.to_s.downcase!
+          character = character.to_s.downcase
 
           unless quoted_characters.include?(character.to_sym)
             raise ArgumentError,
@@ -39,7 +41,7 @@ def saying(source = nil)
         if source.nil?
           source = sample(sourced_sayings).to_s
         else
-          source.to_s.downcase!
+          source = source.to_s.downcase
 
           unless sourced_sayings.include?(source.to_sym)
             raise ArgumentError,

lib/faker/educator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class Educator < Base
     flexible :educator

lib/faker/elder_scrolls.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class ElderScrolls < Base
     class << self

lib/faker/electrical_components.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Faker
   class ElectricalComponents < Base
     flexible :electrical_components