Fix method name in Faker::SingularSiegler #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
requested changes
May 26, 2018
vbrazo
approved these changes
May 26, 2018
vbrazo
reviewed
Jun 14, 2018
| @@ -1,7 +1,7 @@ | |||
| module Faker | |||
| class SingularSiegler < Base | |||
| class << self | |||
| def quotes | |||
There was a problem hiding this comment.
We don't need to deprecate this method because the Faker::SingularSiegler hasn't been released yet.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Renamed quotes to quote to match documentation. * Updated test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
quotestoquoteto match documentation.