Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method name in Faker::SingularSiegler #1257

Merged
merged 2 commits into from
May 26, 2018
Merged

Fix method name in Faker::SingularSiegler #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a104b8
Renamed quotes to quote to match documentation.
mrstebo May 26, 2018
436cc2e
Updated test.
mrstebo May 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/faker/singular_siegler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module Faker
class SingularSiegler < Base
class << self
def quotes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to deprecate this method because the Faker::SingularSiegler hasn't been released yet.

def quote
fetch('singular_siegler.quotes')
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/test_faker_singular_siegler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ def setup
end

def test_quote
assert @tester.quotes.match(/\w/)
assert @tester.quote.match(/\w/)
end
end