Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with vendor prefixes and values #95

Merged
merged 2 commits into from
Aug 14, 2012

Conversation

kizu
Copy link
Member

@kizu kizu commented May 14, 2012

Fixes a part of #19 — with transform transition.

Also, if there would be the gradients without polyfills, it would be easy to support them for border-image etc. (#94)

Also, the code now is a bit crazy, 'cause there are some issues in Stylus (learnboost/stylus#635 and learnboost/stylus#636) that I don't know how to overcome, however I hadn't found any other way to do what I want, so if you'd point me to any that wouldn't break my tests — it would be great.

@tj
Copy link
Collaborator

tj commented May 15, 2012

nice! I worry that this might be a bit brittle but I'll try it out soon with an existing project and see if it breaks anything

@kizu
Copy link
Member Author

kizu commented May 15, 2012

Yeah, ok.

@kizu
Copy link
Member Author

kizu commented Jun 19, 2012

@visionmedia have you tried it already? I used it for myself for a while and it works nice (and all the tests are ok)

Also, those changes would be necessary for the coming gradients rewrite in #94.

@passcod
Copy link

passcod commented Jul 19, 2012

+1

@jgallen23
Copy link

Any update on this one? Would be great to see this merged in

@kizu
Copy link
Member Author

kizu commented Aug 13, 2012

I've rebased this on the master, fixed a minor bug with background-origin/background-clip and removed the box.styl from index.styl, 'cause it's been removed in c8a9091 from file system, but not from the @import.

So, hey, @visionmedia! Did you test it in your project? You said you do. Also, I'm using it in our projects (millions of users daily, yep) and there are no problems yet (but not that much of stylus code yet, but the codebase is growing while we translate the .css files to stylus).

So, please, could you look if it can be merged? It would be nice to have it in there prior to #94.

tj added a commit that referenced this pull request Aug 14, 2012
Working with vendor prefixes and values
@tj tj merged commit 67f964d into stylus:master Aug 14, 2012
@tj
Copy link
Collaborator

tj commented Aug 14, 2012

tests run about ~30% slower, I'll try and remember to compare compile-times for our app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants