Added angle support for linear-gradient #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An ex. linear-gradient(45deg, red, green, blue), linear-gradient(0rad, red, green, blue). If gradient has angle, legacy webkit is ignored.
| end = grad-point(opposite-position(start)) | ||
| webkit-legacy = '-webkit-gradient(linear, %s, %s, %s)' % (grad-point(start) end join-stops(stops, webkit-stop)) | ||
| add-property(prop, replace(val, '__CALL__', webkit-legacy)) | ||
| if start is a 'indent' |
There was a problem hiding this comment.
I made mistake. Should be 'ident'
|
needs some tests if you dont mind |
|
This was already done #94, so when I'll finish it there'd be the angles too. My version would be superior in a lot of ways (with tests!), the only thing left (and that is not in that pull request too) is the handling of the different gradient syntaxes — between the new and old ones. I know that I'm a bit slow now (main work is overwhelming), but! We already use the code from #94 in a running projects, so it somewhat stable right now. But need to be adjusted according to the latest specs, as I already wrote, so wait a bit and it would be there :) |
added 2 commits
August 14, 2012 01:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ex. linear-gradient(45deg, red, green, blue), linear-gradient(0rad, red, green, blue).
If gradient has angle, legacy webkit is ignored.