feat: Bump vscode language server dependencies #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vscode language server dependencies in this extension is 2 major versions behind. There were important changes [between v7 and v8](https://github.com/microsoft/vscode-languageserver-node?tab=readme-ov-file#3170-protocol-800-json-rpc-800-client-and-800-server). * Updated utilities that now return void promises * Added a `deactivate` function to the extension to which is now recommended practice * Replace `onReady` with `onStart` as described in the changelog * Make the log function types more resilient - the `RemoteConsole` contains functions that are not just log functions. Lots of reports have recently reported that 'stylelint does nothing' - running the extension in debug mode to break on unhandled excpetions, it's easy to see that there is client protocol changes since headers are malformed in many requests. Fixes stylelint#498
1 task
ling1726
changed the title
ybiquitous
requested changes
Mar 21, 2024
There was a problem hiding this comment.
@ling1726 Thank you for creating the pull request. And sorry for the late response.
So, can you fix the CI failures?
- Lint: this should be much easier.
- Test: this failure is due to coverage shortage of
deactivate(). You can either add missing cases or just remove the function.
|
@ybiquitous I've fixed the lint issues and added test coverge so the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vscode language server dependencies in this extension is 2 major versions behind. There were important changes between v7 and v8.
deactivatefunction to the extension to which is now recommended practiceonReadywithonStartas described in the changelogRemoteConsolecontains functions that are not just log functions.Lots of reports have recently reported that 'stylelint does nothing' - running the extension in debug mode to break on unhandled excpetions, it's easy to see that there is client protocol changes since headers are malformed in many requests.
I fixed unit tests errors and checked that integration/e2e tests pass
Fixes #498