Skip to content

Commit

Permalink
Prepare 12.0.0 (#187)
Browse files Browse the repository at this point in the history
  • Loading branch information
ybiquitous authored Apr 16, 2023
1 parent e6c8520 commit 7b88d74
Show file tree
Hide file tree
Showing 5 changed files with 157 additions and 154 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 12.0.0

- Removed: `stylelint` less than `15.5.0` from peer dependencies.
- Changed: `declaration-block-no-duplicate-properties` option to `ignore: ['consecutive-duplicates-with-different-syntaxes']`.

## 11.0.0

- Removed: `stylelint` less than `15.3.0` from peer dependencies.
Expand Down
46 changes: 21 additions & 25 deletions __tests__/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,64 +10,60 @@ const invalidCss = fs.readFileSync('./__tests__/invalid.css', 'utf-8');
describe('flags no warnings with valid css', () => {
let result;

beforeEach(() => {
result = stylelint.lint({
beforeEach(async () => {
result = await stylelint.lint({
code: validCss,
config,
});
});

it('did not error', () => {
return result.then((data) => expect(data.errored).toBeFalsy());
it('has no errors', () => {
expect(result.errored).toBe(false);
});

it('flags no warnings', () => {
return result.then((data) => expect(data.results[0].warnings).toHaveLength(0));
expect(result.results[0].warnings).toHaveLength(0);
});
});

describe('flags warnings with invalid css', () => {
let result;

beforeEach(() => {
result = stylelint.lint({
beforeEach(async () => {
result = await stylelint.lint({
code: invalidCss,
config,
});
});

it('did error', () => {
return result.then((data) => expect(data.errored).toBeTruthy());
it('includes an error', () => {
expect(result.errored).toBe(true);
});

it('flags one warning', () => {
return result.then((data) => expect(data.results[0].warnings).toHaveLength(1));
expect(result.results[0].warnings).toHaveLength(1);
});

it('correct warning text', () => {
return result.then((data) =>
expect(data.results[0].warnings[0].text).toBe(
'Unexpected unknown type selector "madeup" (selector-type-no-unknown)',
),
it('corrects warning text', () => {
expect(result.results[0].warnings[0].text).toBe(
'Unexpected unknown type selector "madeup" (selector-type-no-unknown)',
);
});

it('correct rule flagged', () => {
return result.then((data) =>
expect(data.results[0].warnings[0].rule).toBe('selector-type-no-unknown'),
);
it('corrects rule flagged', () => {
expect(result.results[0].warnings[0].rule).toBe('selector-type-no-unknown');
});

it('correct severity flagged', () => {
return result.then((data) => expect(data.results[0].warnings[0].severity).toBe('error'));
it('corrects severity flagged', () => {
expect(result.results[0].warnings[0].severity).toBe('error');
});

it('correct line number', () => {
return result.then((data) => expect(data.results[0].warnings[0].line).toBe(1));
it('corrects line number', () => {
expect(result.results[0].warnings[0].line).toBe(1);
});

it('correct column number', () => {
return result.then((data) => expect(data.results[0].warnings[0].column).toBe(1));
it('corrects column number', () => {
expect(result.results[0].warnings[0].column).toBe(1);
});
});

Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = {
'declaration-block-no-duplicate-properties': [
true,
{
ignore: ['consecutive-duplicates-with-different-values'],
ignore: ['consecutive-duplicates-with-different-syntaxes'],
},
],
'declaration-block-no-shorthand-property-overrides': true,
Expand Down
Loading

0 comments on commit 7b88d74

Please sign in to comment.