Bump up remark dependencies and support only ESM
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[`remark@14`](https://github.com/remarkjs/remark/releases/tag/14.0.0) has been supported only ESM. So, this package needs to become ESM to bump up `remark` dependencies. Here are the installation commands: ```shell npm install \ remark-cli@latest \ remark-frontmatter@latest \ remark-preset-lint-recommended@latest \ remark-preset-prettier@latest \ remark-validate-links@latest npm install 'github:stylelint/eslint-config-stylelint#esm' ``` Note that this change needs the ESLint configuration for ESM. See <stylelint/eslint-config-stylelint#133>
|
The CI failure is due to the https://github.com/stylelint/remark-preset/pull/6/checks?check_run_id=3327452284#step:6:24 It seems that the problem is caused by |
jeddy3
requested changes
Aug 14, 2021
jeddy3
approved these changes
Aug 14, 2021
JounQin
reviewed
Aug 14, 2021
ybiquitous
commented
Aug 15, 2021
| @@ -9,9 +9,11 @@ | |||
| "repository": "stylelint/remark-preset", | |||
| "license": "MIT", | |||
| "author": "stylelint", | |||
| "main": "index.js", | |||
| "type": "module", | |||
| "exports": "./index.js", | |||
There was a problem hiding this comment.
[note] main is replaced with exports via 1ebb623. See the guide "Pure ESM package".
jeddy3
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None.
remark@14has been supported only ESM. So, this package needs to become ESM to bump upremarkdependencies.Here are the installation commands:
npm install \ remark-cli@latest \ remark-frontmatter@latest \ remark-preset-lint-recommended@latest \ remark-preset-prettier@latest \ remark-validate-links@latest npm install 'github:stylelint/eslint-config-stylelint#esm'Note that this change needs the ESLint configuration for ESM. See stylelint/eslint-config-stylelint#133