-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow !default
annotation
#132
Allow !default
annotation
#132
Conversation
a28b254
to
d22879f
Compare
Hmm.. looks like the tests are broken, maybe on master too. Need to have a look at that. |
Seeing messages like "Unknown rule annotation-no-unknown", which suggest #117 might be required first. Side note: you might want to consider replacing tests on Node v12 with tests on Node v18. |
Merged #117, so this needs to be rebased against the current master. Also, an example could be added to |
@Hyzual I made https://github.com/jnoordsij/stylelint-config-recommended-scss/tree/allow-default-annotation to do this. Feel free to cherry-pick it and finish this PR. |
Note that in stylelint-scss/stylelint-scss#666 there's a request for a custom scss version of this rule. If that lands, it would allow for more customised handling and would remove the need for manual configuration. |
d22879f
to
0d646a1
Compare
@jnoordsij Thanks! I've pulled your branch and force-pushed this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good now 👍
Thanks @Hyzual @jnoordsij !
This is valid in Scss, and we use it in `_variables.scss`. stylelint-scss/stylelint-config-recommended-scss#131 stylelint-scss/stylelint-config-recommended-scss#132
In addition to being valid SCSS, we often use `!default` in places like `variables.scss`. stylelint-scss/stylelint-config-recommended-scss#131 stylelint-scss/stylelint-config-recommended-scss#132
In addition to being valid SCSS, we often use `!default` in places like `variables.scss`. stylelint-scss/stylelint-config-recommended-scss#131 stylelint-scss/stylelint-config-recommended-scss#132
This fixes #131