Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per-component classnames #227

Merged
merged 31 commits into from
Jan 11, 2017
Merged

Per-component classnames #227

merged 31 commits into from
Jan 11, 2017

Commits on Nov 21, 2016

  1. proof of concept contextual selector

    @geelen
    geelen committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    6e14952 View commit details
    Browse the repository at this point in the history

  2. hashing the identifiers looks much nicer

    @geelen
    geelen committed Nov 21, 2016
    1 Configuration menu
    Copy the full SHA
    ac37892 View commit details
    Browse the repository at this point in the history

  3. adding empty tag declarations is pretty great for dev tools

    @geelen
    geelen committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    6e317b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2016

  1. Merge branch 'master' into per-component-classname-generation

    @mxstbr
    mxstbr committed Nov 23, 2016
    Configuration menu
    Copy the full SHA
    97f89ee View commit details
    Browse the repository at this point in the history

  2. add a newline before injecting

    @geelen
    geelen committed Nov 23, 2016
    Configuration menu
    Copy the full SHA
    3258c04 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2016

  1. Fix test failures related to the test util 

    These test failures are actually not really failures, they just happened
because we now call the name generator (which we patch for the tests)
on component creation as well as at rendering time, which didn't happen
before, so now all classes are shifted by one. Fixed by manually
shifting them back.
    @mxstbr
    mxstbr committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    67047d4 View commit details
    Browse the repository at this point in the history

  2. Add first support for the private API 

    To add support for server-side rendering, it needs to be possible to
pass in an identifier from the outside. This is a private API because
the only thing ever writing this is babel-plugin-styled-components,
which will automatically turn your normal styled components into the ssr
compatible version by turning your styled() calls into this notation:

    styled({ target: 'div', identifier: 'YourComponent-asdf123', displayName: 'YourComponent' })

This commit adds support for this notation.
    @mxstbr
    mxstbr committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    be90896 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2016

  1. Fix more tests

    @mxstbr
    mxstbr committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    c5098b2 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2016

  1. Merge branch 'master' into per-component-classname-generation

    @mxstbr
    mxstbr committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    013d177 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into per-component-classname-generation

    @mxstbr
    mxstbr committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    ad40aef View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2016

  1. Merge remote-tracking branch 'origin/per-component-classname-generati… 

    …on' into per-component-classname-generation

Conflicts:
	src/models/StyledComponent.js
    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    d7c617b View commit details
    Browse the repository at this point in the history

  2. mergefail

    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    18b14e0 View commit details
    Browse the repository at this point in the history

  3. roll back the empty classname generation

    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    2ade3c5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into per-component-classname-generation

    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    55ecfce View commit details
    Browse the repository at this point in the history

  5. rolling back all the test updates

    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    2662f4b View commit details
    Browse the repository at this point in the history

  6. got the new expanded API going, need to decide in what way to change … 

    …the expectations
    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    303138a View commit details
    Browse the repository at this point in the history

  7. injecting empty style tags for each component is now part of the API.

    @geelen
    geelen committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    5233760 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. fixed all the tests. Having the sc-a on every assertion is a bit nois… 

    …y...
    @geelen
    geelen committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    b18b32c View commit details
    Browse the repository at this point in the history

  2. fleshed out the api tests and added the css alias

    @geelen
    geelen committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    a2fc3bd View commit details
    Browse the repository at this point in the history

  3. couldnt make flow work without breaking overriding

    @geelen
    geelen committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    35b2e3a View commit details
    Browse the repository at this point in the history

  4. updated changelog

    @geelen
    geelen committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    204cf05 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into per-component-classname-generation

    @mxstbr
    mxstbr authored Dec 7, 2016
    Configuration menu
    Copy the full SHA
    c195fed View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2016

  1. Merge remote-tracking branch 'origin/master' into per-component-class… 

    …name-generation

Conflicts:
	CHANGELOG.md
    @geelen
    geelen committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    771ea4c View commit details
    Browse the repository at this point in the history

  2. updated tests

    @geelen
    geelen committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    6ab51f7 View commit details
    Browse the repository at this point in the history

  3. reduced the API to just withConfig

    @geelen
    geelen committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    1e41049 View commit details
    Browse the repository at this point in the history

  4. removed the classes option for withConfig

    @geelen
    geelen committed Dec 16, 2016
    Configuration menu
    Copy the full SHA
    5fd2de5 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2016

  1. broke out the constructor into its own file

    @geelen
    geelen committed Dec 17, 2016
    Configuration menu
    Copy the full SHA
    3416ba4 View commit details
    Browse the repository at this point in the history

  2. added styled native changes too

    @geelen
    geelen committed Dec 17, 2016
    Configuration menu
    Copy the full SHA
    6128ecd View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2017

  1. Merge branch 'v2' into per-component-classname-generation 

    Conflicts:
	CHANGELOG.md
	src/constructors/styled.js
	yarn.lock
    @geelen
    geelen committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    f99a272 View commit details
    Browse the repository at this point in the history

  2. ignoring this error for now

    @geelen
    geelen committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    cae3219 View commit details
    Browse the repository at this point in the history

  3. fixed tests

    @geelen
    geelen committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    9095ea5 View commit details
    Browse the repository at this point in the history