Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix generated component id in non-babel scenario #1755

Merged
merged 8 commits into from
Jun 20, 2018
Merged

fix generated component id in non-babel scenario #1755

merged 8 commits into from
Jun 20, 2018

Conversation

quantizor
Copy link
Contributor

Specifically when two components share the same displayName.

Closes #1715

@quantizor quantizor requested review from kitten and mxstbr May 25, 2018 06:11
@mxstbr-bot
Copy link

mxstbr-bot commented May 25, 2018 •
edited
Loading

Fails
🚫

Please include a CHANGELOG entry. You can find it at CHANGELOG.md

Generated by 🚫 dangerJS

mxstbr
mxstbr previously approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had this kind of code somewhere before with incrementing but it broke something? Not sure anymore tbh, otherwise this LGTM

@quantizor
Copy link
Contributor Author

@Igorbek published this under styled-components@dev if you want to test it out.

@Igorbek
Copy link
Contributor

Igorbek commented Jun 8, 2018

Verified that it is working correctly under styled-components@dev

Igorbek
Igorbek previously approved these changes Jun 8, 2018
View reviewed changes
kitten
kitten previously approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm can’t believe we’ve missed this quirk before 😅

@quantizor
Copy link
Contributor Author

@kitten I’m away for a week, but you’re welcome to merge this whenever 👍

@quantizor quantizor mentioned this pull request Jun 16, 2018
Closed
@quantizor quantizor dismissed stale reviews from kitten and Igorbek via bf4ed48 June 20, 2018 17:55
@quantizor quantizor closed this Jun 20, 2018
@quantizor quantizor reopened this Jun 20, 2018
@quantizor quantizor merged commit 5bc17dc into master Jun 20, 2018
@quantizor quantizor deleted the fix-1715 branch June 20, 2018 18:31
@Ky6uk Ky6uk mentioned this pull request Jun 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr left review comments

@kitten kitten kitten left review comments

@Igorbek Igorbek Igorbek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@quantizor @mxstbr-bot @Igorbek @kitten @mxstbr