Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in insertRuleHelpers.js #1749

Merged
merged 1 commit into from
May 21, 2018
Merged

Fix off-by-one error in insertRuleHelpers.js #1749

merged 1 commit into from
May 21, 2018

Conversation

migueloller
Copy link
Member

See here for more info.

@mxstbr-bot
Copy link

mxstbr-bot commented May 21, 2018 •
edited
Loading

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

kitten
kitten previously approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for submitting a quick PR for me 🙌 this is luckily not an API that’s used right now. Not sure if a separate PR was even necessary but here goes nothing ;)

CHANGELOG.md Outdated
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file. If a contri

## Unreleased

- Fix off-by-one error in insertRuleHelpers.js, my @migueloller (see #1749)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the two links for the PR and your username please? There’s also a small typo: “my”

Copy link
Member Author

@migueloller migueloller May 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! This is fixed now.

@kitten kitten merged commit 36345f7 into styled-components:master May 21, 2018
@mxstbr
Copy link
Member

mxstbr commented May 21, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitten kitten kitten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@migueloller @mxstbr-bot @mxstbr @kitten