Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested + lowercase components #220

Closed
wants to merge 3 commits into from
Closed

Support nested + lowercase components #220

wants to merge 3 commits into from

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Apr 22, 2019

This is to support the Animated library used by react-spring with the css prop.

Pseudocode to illustrate:

// in
<animated.div css="color: red" />
// out (before the change)
styled("animated.div")`
  color: red
`
// out (after the change)
styled(animated.div)`
  color: red
`

@bpierre
Copy link
Contributor Author

bpierre commented Jun 10, 2019

Is there anything I can do to make this easier to review?

@quantizor
Copy link
Collaborator

I'm going to merge your PR into mine as it has some other css prop changes and the fixtures are going to have further merge conflicts

@quantizor
Copy link
Collaborator

Cherry-picked over to #228 with authorship retained, thanks!

@quantizor quantizor closed this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants