Improved #4 / 3494: AVX2 bugfixes + no code duplication for the integer workhorses in there #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation: for TFloat to work, we don't need to duplicate the integer work functions as it's only the ExtractResults16[8,16] functions that need different implementations for float vs. double. These are therefor common to both implementations:
```
static void PartialMatrixDotVector64(const int8_t *wi, const TFloat *scales, const int8_t *u,
int num_in, TFloat *v) {
static void PartialMatrixDotVector32(const int8_t *wi, const TFloat *scales, const int8_t *u,
int num_in, TFloat *v) {
static void PartialMatrixDotVector16(const int8_t *wi, const TFloat *scales, const int8_t *u,
int num_in, TFloat *v) {
static inline void PartialMatrixDotVector8(const int8_t *wi, const TFloat *scales, const int8_t *u,
int num_in, TFloat *v) {
static void matrixDotVector(int dim1, int dim2, const int8_t *wi, const TFloat *scales,
const int8_t *u, TFloat *v) {
```
This was referenced Jul 13, 2021
|
annulled due to #2 (comment). Given the goals specified there, these functions must exist in both float and double instantiation anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved #4 / tesseract-ocr#3494: AVX2 bugfixes + no code duplication for the integer workhorses in there tesseract-ocr#3495
same as patch-4 (tesseract-ocr#3494) but now with reduced code duplication: for TFloat to work, we don't need to duplicate the integer work functions as it's only the ExtractResults[8,16] functions that need different implementations for float vs. double. These are therefor common to both implementations:
(extract from tesseract-ocr#3490)