fix: Fix non-nullable union types #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuebingerb
force-pushed
the
fix/fix-non-nullable-union-types
branch
2 times, most recently
from
69e0458 to
1aa6367
Compare
stuebingerb
commented
Dec 16, 2024
| @@ -112,6 +112,12 @@ class SchemaPrinterTest { | |||
| } | |||
| } | |||
| } | |||
| unionProperty("nullablePdf") { | |||
| returnType = linked | |||
| nullable = true | |||
There was a problem hiding this comment.
Would be good to read nullability (and also iterability) from the actual type but with the current implementation it is hard (if not impossible) to do so. As of now there doesn't seem to be a way to define a union property of lists for a non-sealed class.
stuebingerb
force-pushed
the
fix/fix-non-nullable-union-types
branch
3 times, most recently
from
8cc47da to
3aed18f
Compare
Resolves #135
stuebingerb
force-pushed
the
fix/fix-non-nullable-union-types
branch
from
3aed18f to
fe52c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #135