refactor: Cleanup SchemaProxy
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are running (and there are several related ones) but removing the |
stuebingerb
commented
Dec 11, 2024
| @@ -461,4 +453,10 @@ class SchemaCompilation( | |||
| transformation = transformation as Transformation<T, R>? | |||
| ) | |||
| } | |||
|
|
|||
| private fun typenameField(functionWrapper: FunctionWrapper<String>) = Field.Function( | |||
There was a problem hiding this comment.
This definition skips all stuff previously done in handleOperation but IMHO that stuff is not necessary for the __typename: We already know the return type and we know that there are no input values.
stuebingerb
commented
Dec 11, 2024
| }, true)) | ||
| ) | ||
| val __typenameField = typenameField(FunctionWrapper.on({ value: Any -> | ||
| queryTypeProxies[value.javaClass.kotlin]?.name ?: error("No query type proxy found for $value") |
There was a problem hiding this comment.
typeByKClass is doing model.queryTypes[kClass] with queryTypes = queryTypeProxies + enums + scalars, so a bit different.
IMHO this is still fine as according to the spec the __typename is available "on any Object, Interface, or Union" - i.e. no enums or scalars.
stuebingerb
force-pushed
the
refactor/cleanup-schema-proxy
branch
3 times, most recently
from
ff0d534 to
05fd701
Compare
stuebingerb
changed the base branch from
main
to
fix/fix-non-nullable-union-types
stuebingerb
force-pushed
the
refactor/cleanup-schema-proxy
branch
from
05fd701 to
6f67c79
Compare
stuebingerb
changed the base branch from
fix/fix-non-nullable-union-types
to
main
stuebingerb
force-pushed
the
refactor/cleanup-schema-proxy
branch
from
6f67c79 to
a039cad
Compare
stuebingerb
changed the base branch from
main
to
fix/fix-non-nullable-union-types
stuebingerb
force-pushed
the
fix/fix-non-nullable-union-types
branch
from
3aed18f to
fe52c50
Compare
`SchemaProxy` is (from my understanding) only a wrapper for schema introspection, and as such should not need to deal with Kotlin classes or offer execution options. This commit also removes some more unused code.
stuebingerb
force-pushed
the
refactor/cleanup-schema-proxy
branch
from
a039cad to
3b4af49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemaProxyis (from my understanding) only a wrapper for schema introspection, and as such should not need to deal with Kotlin classes or offer execution options. This commit also removes some more unused code.