refactor: Reduce coupling with Type #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuebingerb
force-pushed
the
refactor/reduce-type-coupling
branch
8 times, most recently
from
bfb62a1 to
2406400
Compare
stuebingerb
force-pushed
the
docs/cleanup-documentation
branch
2 times, most recently
from
3f8c00e to
78c6815
Compare
stuebingerb
force-pushed
the
refactor/reduce-type-coupling
branch
2 times, most recently
from
ff596cf to
c1fbe34
Compare
stuebingerb
force-pushed
the
refactor/reduce-type-coupling
branch
3 times, most recently
from
ca6f6b4 to
36172d7
Compare
stuebingerb
changed the base branch from
main
to
refactor/cleanup-schema-proxy
stuebingerb
force-pushed
the
refactor/cleanup-schema-proxy
branch
from
6f67c79 to
a039cad
Compare
stuebingerb
force-pushed
the
refactor/reduce-type-coupling
branch
from
36172d7 to
92bdfd4
Compare
stuebingerb
force-pushed
the
refactor/cleanup-schema-proxy
branch
from
a039cad to
3b4af49
Compare
stuebingerb
force-pushed
the
refactor/reduce-type-coupling
branch
2 times, most recently
from
85b354e to
9625454
Compare
The current implementation is heavily coupled to `Type` which itself is heavily coupled to actual Kotlin classes. This tries to move away from `Type` when it is not needed to simplify working with non-Kotlin schemas (like schemas created from SDL or introspection queries).
stuebingerb
force-pushed
the
refactor/reduce-type-coupling
branch
from
9625454 to
b46b0c3
Compare
stuebingerb
changed the title
mervyn-mccreight
approved these changes
Dec 20, 2024
| fun isList(): Boolean = when { | ||
| kind == TypeKind.LIST -> true | ||
| ofType == null -> false | ||
| else -> (ofType as __Type).isList() |
There was a problem hiding this comment.
Would (ofType as? __Type)?.isList() ?: false also work here without the second when case plus it would be a safe cast?
There was a problem hiding this comment.
Would work, yes. The current cast should also be safe, though, shouldn't it? I'll have a look in my next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is heavily coupled to
Typewhich itself is heavily coupled to actual Kotlin classes. This tries to move away fromTypewhen it is not needed to simplify working with non-Kotlin schemas (like schemas created from SDL or introspection queries).