This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Move the new pattern logic into another file and unit test it #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
saving-pattern-data-phil
to
update/saving-pattern-data
February 16, 2023 19:37
kienstra
commented
Feb 16, 2023
| @@ -131,7 +131,7 @@ function format_pattern_data( $pattern_data, $file ) { | |||
| * | |||
| * @return array | |||
| */ | |||
| function get_theme_patterns() { | |||
| function get_theme_patterns(): array { | |||
There was a problem hiding this comment.
Forgot to do this before
kienstra
commented
Feb 16, 2023
| 'slug' => $new_name, | ||
| 'title' => $new_title, | ||
| ) | ||
| ); |
There was a problem hiding this comment.
This is copy-pasted into get_new_pattern() so we can unit test it.
There was a problem hiding this comment.
No intended change to how it works.
|
Thanks so much, @mike-day! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logic to get a new pattern into a pure function, and unit tests it.
No intended change to how this works.
How to test
Not needed