This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fix: Remove extra comma which is inserted for themes without a textdomain #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-day
approved these changes
Aug 10, 2023
kienstra
approved these changes
Aug 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Summary of changes
If a theme doesn't have a TextDomain, patterns that have custom categories will have an extra comma in the PHP code, causing a fatal error.
How to test
TextDomainin the style.css fileRelated:
https://wordpress.org/support/topic/creating-custom-category-causes-fatal-error/#post-16961268