This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Rename ThemePatterns/ to Patterns/
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
changed the base branch from
main
to
update/category-filtering-same-place
kienstra
commented
Jan 20, 2023
| @@ -19,7 +19,7 @@ type Props = { | |||
| isVisible: boolean; | |||
| }; | |||
|
|
|||
| export default function ThemePatterns( { isVisible }: Props ) { | |||
| export default function Patterns( { isVisible }: Props ) { | |||
There was a problem hiding this comment.
There's also a Patterns type, so this isn't great.
There was a problem hiding this comment.
Oh good point. I suppose we could just alias the Patterns type when importing if there was a conflict. Or the component could be PatternsOverview, though that's admittedly not what we're calling it 😆
There was a problem hiding this comment.
Haha, yeah. It's a tough one, I blanked on different names.
mike-day
approved these changes
Jan 20, 2023
|
@mike-day, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThemePatterns/toPatterns/ThemePatterns/doesn't apply to Pattern Manager, though it was for FSE StudioHow to test
Not needed