This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Move patternsRef.current into filteredPatterns
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
commented
Jan 19, 2023
|
|
||
| const patternsRef = useRef( themePatterns ); | ||
| const filteredPatterns = searchTerm.trim() |
There was a problem hiding this comment.
filteredPatterns is like patternsRef.current
Ideally, filteredPatterns would also filter by category here, like how PatternGrid does that.
kienstra
commented
Jan 19, 2023
| className="pattern-search" | ||
| value={ searchInput } | ||
| onChange={ ( searchTerm ) => { | ||
| const matchedPatterns = Object.keys( |
There was a problem hiding this comment.
This logic is just moved to ThemePatterns/index.tsx
kienstra
changed the title
ThemePatternspatternsRef.current into filteredPatterns
|
This PR probably needs cleanup, but you get the idea 😄 |
|
This is awesome! The intent is clearer, we should absolutely use this idea. |
|
Thanks so much! Haha, React state is so hard, it doesn't have a good notion of derived or computed state. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useEffect()