Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Cleanup for version control PR #151

Merged
merged 2 commits into from
May 1, 2023
Merged

Conversation

mike-day
Copy link
Contributor

@mike-day mike-day commented May 1, 2023

Summary of changes

This is a very simple PR that cleans up some of my own work in #145.

This PR removes an extraneous type in App, removes a comment left in error in GetVersionControlTest, and performs some nitpicky formatting in GetVersionControlTest.


How to test

Not needed — there are no functional changes to code.

@mike-day mike-day marked this pull request as ready for review May 1, 2023 19:28
Copy link
Contributor

@kienstra kienstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mike-day,
This looks good!

$this->get_mock_dismissed_themes(),
get_dismissed_themes(),
);
$this->assertSame( $this->get_mock_dismissed_themes(), get_dismissed_themes() );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget that phpcs doesn't do formatting like prettier. Strange, huh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very strange!

@mike-day mike-day merged commit 8634d4f into main May 1, 2023
@mike-day mike-day deleted the chore/cleanup-get-version-control branch May 1, 2023 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants