This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Make the core save button work #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstonphilip
requested review from
kienstra,
mike-day,
mikemcalister and
dreamwhisper
johnstonphilip
commented
Jan 18, 2023
|
|
||
| const editorDirty = useRef( false ); | ||
| const [ siteEditorDirty, setSiteEditorDirty ] = useState( false ); | ||
| const [ requestPatternRefresh, setRequestPatternRefresh ] = |
There was a problem hiding this comment.
I also removed some dead code here relating to the site editor
kienstra
approved these changes
Jan 18, 2023
|
|
||
| useEffect( () => { | ||
| const saveButtons = document.getElementsByClassName( | ||
| 'editor-post-publish-panel__toggle' |
There was a problem hiding this comment.
This class could change, but it's better than importing the whole testing-library to search for the button text.
| } | ||
|
|
||
| // While the above event listeners handle interrupting save button clicks, this also handles keyboard shortcut saves (like cmd+s). | ||
| subscribe( () => { |
There was a problem hiding this comment.
It'd be nice if Gutenberg and React had a better event hook system, but this is what we have.
| @@ -30,21 +30,8 @@ export default function usePatterns( initialPatterns: Patterns ) { | |||
| window.addEventListener( | |||
| 'message', | |||
| ( event ) => { | |||
| if ( event.data === 'patternmanager_site_editor_dirty' ) { | |||
There was a problem hiding this comment.
Thanks for removing the FSES-specific code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR un-hides the "Save" button in the pattern editor, and makes it work.
What this PR does not do: