Scrape Wayback Machine instead of J-Archive (w/ fallback) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid (in most cases) scraping JArchive directly by scraping the wayback machine instead
|
Whoops, didn't mean to throw in an old spec file. |
|
Seems like these changes have been incorporated in the recent pull request #17, is this correct? If so is this safe to close? |
|
I accidentally stuck part of it in #17 but not the whole thing. It still needs to be merged if you like this functionality. |
Bumps [requests](https://github.com/psf/requests) from 2.28.1 to 2.31.0. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.28.1...v2.31.0) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.2 to 6.3.2. - [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst) - [Commits](tornadoweb/tornado@v6.2.0...v6.3.2) --- updated-dependencies: - dependency-name: tornado dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…31.0 Bump requests from 2.28.1 to 2.31.0
Bump tornado from 6.2 to 6.3.2
stuartthomas25
added a commit
that referenced
this pull request
May 26, 2023
Scrape Wayback Machine instead of J-Archive (w/ fallback)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9.
This is a really simple implementation and works quite well. Right now, it will still fall back on scraping J-Archive directly when the game is not saved in the Wayback. It is only 1-5 seconds slower in my experience.