Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon status area position #8

Merged
merged 13 commits into from
May 21, 2022
Merged

Conversation

oqo0
Copy link
Contributor

@oqo0 oqo0 commented May 20, 2022

Pull request summary:

I'm constantly changing the language and I don't want to see the icon of this extension next to it.
If the icon of this extension is to the right of the language icon, then this is not entirely intuitive. I suggest shifting the icon to the left to solve this problem.

UI related changes:

change

@stuarthayhurst
Copy link
Owner

How about this as a setting? I'll backport the settings code from one of my other extensions later if that sounds good :)

@oqo0
Copy link
Contributor Author

oqo0 commented May 20, 2022

Great idea. Thank you.

@stuarthayhurst
Copy link
Owner

That's the UI and build system changes implemented, the new setting has functionality, but needs the extension to be toggled on and off for it to take effect for now until I fix that

@stuarthayhurst
Copy link
Owner

If you're happy with this, I'll merge :)
If you want to test it, it should be the usual make build install, restart GNOME and then check the settings

@oqo0
Copy link
Contributor Author

oqo0 commented May 21, 2022

I tested it and it works just great. Nice job. Cheers.

@stuarthayhurst stuarthayhurst merged commit 258cfdd into stuarthayhurst:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants