Skip to content

Commit

Permalink
Merge pull request #51765 from mitake/etcd3-compaction
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 51765, 53053, 52771, 52860, 53284). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add an option for turning on/off compaction from apiserver in etcd3 mode

…erver

**What this PR does / why we need it**:

This commit adds an option for controlling request of compaction to
etcd3 from apiserver. There is a situation that apiserver cannot fully
own its etcd cluster (e.g. sharing it with canal). In such a case,
apiserver should have limited access in terms of etcd's auth
functionality so it don't have a privilege to issue compaction
requests. It means that the compaction requests should be issued by
other component and apiserver's compaction requests are needless.

For such use cases, this commit adds a new flag
storagebackend.Config.DoCompaction. If the flag is true (default),
apiserver issues the compaction requests like current behaviour. If it
is false, apiserver doesn't issue the requests.

**Related issue (etcd)**
etcd-io/etcd#8458
/cc @xiang90 @struz

**Release note:**
```release-note
Add --etcd-compaction-interval to apiserver for controlling request of compaction to etcd3 from apiserver.
```

Kubernetes-commit: 5dfea9e6091a818f90e8df5afcc750b5f01fa9b7
  • Loading branch information
k8s-publish-robot committed Oct 16, 2017
2 parents 78c14f6 + a7bf68f commit b30f4cd
Show file tree
Hide file tree
Showing 5 changed files with 287 additions and 225 deletions.
Loading

0 comments on commit b30f4cd

Please sign in to comment.