Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Implement new algorithm data flow #74

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Conversation

stsievert
Copy link
Owner

What does this PR implement?
It reorganizes the data flow so the algorithm always posts a complete search. Prior to this PR, algorithms would search for N queries, post those queries, then repeat with 2N queries.

Reference issues/PRs
This PR closes #72.

@stsievert
Copy link
Owner Author

This also PR also does the following:

  • Makes sure random_state is piped correctly so the number of queries in the database grows.
  • Fixes a typo to prevent the queries from being cleared.
  • Allows the targets key in init.yaml to be an int (which allows for easier testing)

@stsievert stsievert changed the title ENH: Implement new algorithm data flow MAINT: Implement new algorithm data flow Sep 18, 2020
@stsievert stsievert force-pushed the query-search-dataflow branch from 24259a8 to 88a6f61 Compare September 18, 2020 21:25
@stsievert stsievert merged commit 9f37b48 into master Sep 22, 2020
@stsievert stsievert deleted the query-search-dataflow branch September 22, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink query search/model update dataflow
1 participant